I will admit, that having grown up with nintendo and not getting into playstation until a few years ago I am heavily biased.
my favorite game controller has got to be the wii remote/attachments.
I also like the switch controllers, but I haven't used them much.
out of the non-nintendo controllers I've used, I quite like PS4 controllers (the PS3 ones are fine, just a bit smaller)
I've played on that once for about ten minutes...
oh, and I found this one day:
which is just awesome